Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data, model, and algo that FedSAM needs #453

Merged
merged 9 commits into from
Dec 8, 2022
Merged

Conversation

joneswong
Copy link
Collaborator

We are reproducing the experiments of FedSAM.

@joneswong joneswong added the Feature New feature label Dec 5, 2022
@joneswong joneswong requested a review from rayrayraykk December 5, 2022 16:15
@joneswong
Copy link
Collaborator Author

BTW, we fix a bug in calling registered splitters.

@rayrayraykk rayrayraykk linked an issue Dec 6, 2022 that may be closed by this pull request
@joneswong joneswong changed the title [WIP] add data, model, and algo that FedSAM needs add data, model, and algo that FedSAM needs Dec 7, 2022
rayrayraykk
rayrayraykk previously approved these changes Dec 7, 2022
Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rayrayraykk rayrayraykk merged commit d66044a into master Dec 8, 2022
@joneswong joneswong deleted the dev_sharpness branch December 12, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect implementation of the contributed splitter
2 participants