Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind lager_better with each metric #522

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Bind lager_better with each metric #522

merged 2 commits into from
Feb 13, 2023

Conversation

rayrayraykk
Copy link
Collaborator

@rayrayraykk rayrayraykk commented Feb 13, 2023 •
edited
Loading

This PR is part of #486 .

@rayrayraykk rayrayraykk added the FedHPO FedHPO related label Feb 13, 2023
joneswong
joneswong approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@joneswong joneswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Some functionalities are required now. The trial_id arg is not a good design imo.

@joneswong joneswong merged commit 49b342d into alibaba:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joneswong joneswong joneswong approved these changes

Assignees
No one assigned
Labels
FedHPO FedHPO related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayrayraykk @joneswong