Add random forest in VFL #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbc2016
reviewed
Feb 15, 2023
qbc2016
reviewed
Feb 15, 2023
| return np.sum(left_child_indicator) / total_num * left_gini + sum( | ||
| right_child_indicator) / total_num * right_gini | ||
|
|
||
| def cal_sse(self, split_idx, y, indicator): |
There was a problem hiding this comment.
Actually, "sse" means "Sum of Square Error of two subtrees", should we rename it?
There was a problem hiding this comment.
sse -> sum_of_square_mean_err
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is adapted from #501 , and many thanks for contributions from @qbc2016 !
The modifications in this pr includes:
vertical.data_size_for_debug: only use a subset for running vfl when debuggingmeanandsumoperations when calculating loss/accHow to apply random forest:
vertical.algo='rf'andmodel.type = 'random_forest'@rayrayraykkTodo: