Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Editor): Move editorId from GGEditor into Editor as id #56

Merged
merged 1 commit into from
Sep 12, 2018
Merged

refactor(Editor): Move editorId from GGEditor into Editor as id #56

merged 1 commit into from
Sep 12, 2018

Conversation

tennisonchan
Copy link
Contributor

So that we don't need to pass the editorId down the context.

@tennisonchan tennisonchan requested a review from gaoli September 12, 2018 01:43
@gaoli
Copy link
Collaborator

gaoli commented Sep 12, 2018

👍

@tennisonchan tennisonchan merged commit 0485863 into master Sep 12, 2018
@tennisonchan tennisonchan deleted the refactor_editorId branch September 12, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoli gaoli Awaiting requested review from gaoli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tennisonchan @gaoli