improve (dns): support domain group manage and modify ali_dns_domain #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixue323
changed the title
lixue323
force-pushed
the
dns
branch
4 times, most recently
from
0e17e53 to
b32303b
Compare
xiaozhu36
requested changes
Nov 28, 2019
| """ | ||
|
|
||
| RETURN = ''' | ||
| dns: |
| - Create, Delete Alicloud cloud DNS group(DNS group). | ||
| It supports updating group name and domain group. | ||
| options: | ||
| domain_name: |
xiaozhu36
requested changes
Dec 2, 2019
| - Create, Delete Alicloud cloud DNS group(DNS group). | ||
| It supports updating group name. | ||
| options: | ||
| group_id: |
xiaozhu36
requested changes
Dec 2, 2019
| - This module fetches data from the Open API in Alicloud. | ||
| The module must be called from within the group itself. | ||
| options: | ||
| domain_count: |
lixue323
force-pushed
the
dns
branch
4 times, most recently
from
b764738 to
809dbbb
Compare
xiaozhu36
requested changes
Dec 2, 2019
| - Whether or not to create, delete DNS group. | ||
| choices: ['present', 'absent'] | ||
| default: 'present' | ||
| new_group_name: |
There was a problem hiding this comment.
new group name 去掉吧，这个name就不支持修改了
| try: | ||
| for v in dns_conn.describe_domain_groups(): | ||
| if v.name == group_name: | ||
| matching_dns.append(v) |
There was a problem hiding this comment.
我理解不用matching_dns了，找到了直接返回就行
| - This module fetches data from the Open API in Alicloud. | ||
| The module must be called from within the group itself. | ||
| options: | ||
| domain_count: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.