Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync inner fix #634

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Sync inner fix #634

merged 7 commits into from
Nov 14, 2023

Conversation

johnlanni
Copy link
Collaborator

@johnlanni johnlanni commented Nov 13, 2023

Ⅰ. Describe what this PR did

fix some parse issues in the header control, rewrite and retry.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Merging #634 (e493e76) into main (57b8cb1) will decrease coverage by 0.23%.
Report is 1 commits behind head on main.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
- Coverage   35.41%   35.18%   -0.23%     
==========================================
  Files          71       71              
  Lines       10244    10253       +9     
==========================================
- Hits         3628     3608      -20     
- Misses       6331     6357      +26     
- Partials      285      288       +3     
Files Coverage Δ
pkg/ingress/kube/annotations/header_control.go 90.62% <50.00%> (-5.93%) ⬇️

... and 1 file with indirect coverage changes

@johnlanni johnlanni merged commit 5174397 into alibaba:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants