more compatiable with nginx's rewrite #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnlanni
requested review from
Xunzhuo,
SpecialYang and
Charlie17Li
as code owners
|
cc @SpecialYang |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
+ Coverage 35.46% 35.51% +0.05%
==========================================
Files 71 71
Lines 10259 10268 +9
==========================================
+ Hits 3638 3647 +9
Misses 6333 6333
Partials 288 288
|
SpecialYang
reviewed
Nov 14, 2023
| if strings.ContainsAny(path, `\.+*?()|[]{}^$`) { | ||
| return true | ||
| } | ||
| if strings.ContainsAny(i.Rewrite.RewriteTarget, `$\`) { |
There was a problem hiding this comment.
$1 $2是nginx的捕获方式，\1 \2 是 envoy 的捕获方式
| @@ -17,7 +17,6 @@ kind: Ingress | |||
| metadata: | |||
| annotations: | |||
| nginx.ingress.kubernetes.io/rewrite-target: "/$1" | |||
| nginx.ingress.kubernetes.io/use-regex: "true" | |||
There was a problem hiding this comment.
不带 use-regex 时，通过 target 或 path 里的特殊字符来判定是否启用正则匹配
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews