Optical center relative to the image center #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
changed the title
fabiencastan
requested changes
Jul 23, 2021
ghost
force-pushed
the
dev/offsetFromCenter
branch
2 times, most recently
from
f346c9d to
7cf9b06
Compare
fabiencastan
requested changes
Aug 13, 2021
src/aliceVision/version.hpp
Outdated
Comment on lines
26
to
42
| inline bool isVersionOlder(const Vec3 & version, const Vec3 & base) | ||
| { | ||
| for (Vec3::Index i = 0; i < 3; i++) | ||
| { | ||
| if (version[i] < base[i]) | ||
| { | ||
| return true; | ||
| } | ||
|
|
||
| if (version[i] > base[i]) | ||
| { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
class Version
{
public:
Version(const Vec3&);
Version(int major, int minor, int micro);
bool operator<(const Vec3& other) const;
private:
Vec3 _v;
};
Comment on lines
+32
to
+33
| const double ppx = 2020.0 - (double(w) / 2.0); | ||
| const double ppy = 1040.0 - (double(h) / 2.0); |
There was a problem hiding this comment.
Suggested change
| const double ppx = 2020.0 - (double(w) / 2.0); | |
| const double ppy = 1040.0 - (double(h) / 2.0); | |
| const double ppx = -26; | |
| const double ppy = 16; |
src/aliceVision/version.hpp
Outdated
| } | ||
|
|
||
| private: | ||
| Vec3 _v; |
There was a problem hiding this comment.
Suggested change
| Vec3 _v; | |
| Vec3i _v; |
There was a problem hiding this comment.
It's obvious that integers are better suited for this task.
However, i choose doubles as Json I/O has always loaded/saved doubles.
fabiencastan
force-pushed
the
dev/offsetFromCenter
branch
from
5ed3d73 to
3ef5de8
Compare
… to the image center The "principal point" (or optical center) was relative to the top-left corner of the image. It is now defined as an "offset" relative to the image center.
Need to have the same width/height in View and Intrinsic
fabiencastan
force-pushed
the
dev/offsetFromCenter
branch
from
c1e1a87 to
ad65482
Compare
simogasp
reviewed
Aug 18, 2021
fabiencastan
force-pushed
the
dev/offsetFromCenter
branch
4 times, most recently
from
46086cd to
4b2d4cc
Compare
fabiencastan
force-pushed
the
dev/offsetFromCenter
branch
from
4b2d4cc to
85dd16d
Compare
3 tasks
fabiencastan
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace principal point with offset from image center in camera internal description