Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change focal length in sfmData file formats #1098

Merged
merged 16 commits into from
Apr 22, 2022
Merged

Conversation

fabiencastan
Copy link
Member

Description

Changes storage of focal in file formats:

  • Focal is now in millimeter (instead of pixels).
  • Focal is no more split on (x, y) but use focal and pixel ratio.

@fabiencastan fabiencastan added this to the 2.5.0 milestone Aug 19, 2021
@fabiencastan fabiencastan changed the title Change focal length in sfmData file formats WIP Change focal length in sfmData file formats Aug 19, 2021
@fabiencastan fabiencastan changed the title WIP Change focal length in sfmData file formats Change focal length in sfmData file formats Apr 11, 2022
@simogasp
Copy link
Member

it would be better to have the possibility to keep the focal length in pixel as it is the standard way in computer vision to define the intrinsics. without it will be hard to e.g. run evaluation benchmarks that probably won't have the camera information to recover the information in mm

Co-authored-by: Simone Gasparini <[email protected]>
@fabiencastan
Copy link
Member Author

@simogasp The focal length is still stored in pixels. There is only a conversion to read/write to the file formats.

@fabiencastan fabiencastan merged commit 0f7c953 into develop Apr 22, 2022
@fabiencastan fabiencastan deleted the dev/focalMillimeter branch April 22, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants