-
-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change focal length in sfmData file formats #1098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
changed the title
Change focal length in sfmData file formats
WIP Change focal length in sfmData file formats
Aug 19, 2021
fabiencastan
commented
Aug 19, 2021
fabiencastan
commented
Aug 19, 2021
fabiencastan
commented
Aug 19, 2021
fabiencastan
commented
Aug 23, 2021
fabiencastan
force-pushed
the
dev/focalMillimeter
branch
from
August 24, 2021 09:03
04a5f1a
to
ad75b65
Compare
Use offset to avoid confusion on the coordinate system and make it clear that it is relative to the center.
servantftechnicolor
force-pushed
the
dev/focalMillimeter
branch
from
March 12, 2022 11:39
a196873
to
ba07cd4
Compare
This was referenced Mar 25, 2022
fabiencastan
changed the title
WIP Change focal length in sfmData file formats
Change focal length in sfmData file formats
Apr 11, 2022
simogasp
reviewed
Apr 11, 2022
simogasp
reviewed
Apr 11, 2022
it would be better to have the possibility to keep the focal length in pixel as it is the standard way in computer vision to define the intrinsics. without it will be hard to e.g. run evaluation benchmarks that probably won't have the camera information to recover the information in mm |
Co-authored-by: Simone Gasparini <[email protected]>
@simogasp The focal length is still stored in pixels. There is only a conversion to read/write to the file formats. |
fabiencastan
commented
Apr 21, 2022
fabiencastan
commented
Apr 21, 2022
fabiencastan
commented
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes storage of focal in file formats: