[CMake] Use list for storing flags for target_compile_definitions #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabiencastan Without this PR builds on Windows will fail on current |
simogasp
previously approved these changes
Sep 26, 2022
It turns out that Visual Studio generator do not split the definitions string passed to target_compile_definitions using spaces as separators, like on other generators such as Ninja. Multiple definitions thus need to passed as a list.
fcastan
force-pushed
the
fix-msvc-build
branch
from
b334815 to
e500d9c
Compare
fabiencastan
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that Visual Studio generator do not split the definitions string passed to target_compile_definitions using spaces as separators, like on other generators such as Ninja. Multiple definitions thus need to passed as a list.
This PR fixes b7184ee