Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(trivial) Extract removePoorlyOverlappingImagePairs() #1288

Merged
merged 1 commit into from
Oct 18, 2022
Merged

(trivial) Extract removePoorlyOverlappingImagePairs() #1288

merged 1 commit into from
Oct 18, 2022

Conversation

p12tic
Copy link
Contributor

@p12tic p12tic commented Oct 16, 2022

This extract another function that I've found useful into a module from where it can be reused.

@p12tic p12tic force-pushed the reuse-feature-matching branch from 2b117fa to 939dfeb Compare October 17, 2022 05:51
@p12tic
Copy link
Contributor Author

p12tic commented Oct 17, 2022

@simogasp Thanks for review, I've addressed your comment.

@simogasp simogasp added this to the 2.5.0 milestone Oct 17, 2022
simogasp
simogasp approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@simogasp simogasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabiencastan fabiencastan merged commit fa51fc8 into alicevision:develop Oct 18, 2022
@p12tic p12tic deleted the reuse-feature-matching branch October 20, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simogasp simogasp simogasp approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@p12tic @simogasp @fabiencastan