Add compression option for exr and jpg images #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| outputSpec.attribute("compression", compressionMethod_str); | ||
|
|
There was a problem hiding this comment.
Duplicate of write image content, maybe create a function ?
There was a problem hiding this comment.
Not an exact duplicate (no jpg case) but we could create a function for exr case or a more generic one with a parameter for the image type.
Add new input options compressionMethod and compressionLevel in imageProcessing and panoramaPostProcessing.
mugulmd
force-pushed
the
dev/compressionImage
branch
from
d3ffed2 to
3969c7e
Compare
mugulmd
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new input options compressionMethod and compressionLevel in imageProcessing and panoramaPostProcessing.
CompressionLevel acts as "Quality" parameter for jpeg images and relies on selected method or exr images.
References
JPEG compression: https://openimageio.readthedocs.io/en/v2.4.11.1/builtinplugins.html#jpeg
EXR compression: https://openimageio.readthedocs.io/en/v2.4.11.1/builtinplugins.html#openexr