[Meshing] Fix to avoid small holes in the final mesh #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using a bounding box, the surfaces near the boundaries would have holes in them and there would be a double surface effect on the boundary
fabiencastan
approved these changes
Jun 3, 2023
fabiencastan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a surface is close to the specified bounding box, a lot of small holes in the corresponding mesh appear. Additionally, there's a double surface phenomena that is created where an irregular surface appears behind the actual surface in question.
Without manual bounding box (before fix)
With manual bounding box (before fix)
Without manual bounding box (after fix)
With manual bounding box (after fix)