[software] Do not fail if range start is larger than the number of views #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
reviewed
Jun 8, 2023
For cases where a node declares a size that is bigger than it actually is, the start of ranges might exceed the number of views in the SfMData. Instead of causing an EXIT_FAILURE, we detect that the size of the range is incorrect to proceed with computations, and return EXIT_SUCCESS. This allows to use nodes such as the `KeyframeSelection`, for which the number of outputs can rarely be known before the end of the computations: if the number of chunks for `PrepareDenseScene` and `FeatureExtraction` is too large for the actual size of `KeyframeSelection`, then we keep on going through the pipeline instead of failing.
cbentejac
force-pushed
the
dev/chunkableKeyframeSelection
branch
from
07eaa88 to
222b020
Compare
fabiencastan
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Meshroom pull request: alicevision/Meshroom#2039
This PR changes the behaviour of nodes with chunks that check the validity of the ranges they are provided with. Instead of causing an
EXIT_FAILUREwhen the starting point of the range exceeds the number of views in the SfMData, we detect whether the size of the range with this starting point is negative (which means that the chunks were created based on erroneous information), and skip the computations before returningEXIT_SUCCESS.This allows to use chunks after nodes whose announced size does not always correspond to the reality, because their number of outputs cannot be precisely determined before their computation.
This PR affects the
PrepareDenseSceneandFeatureExtractionexecutables.