Remove internal flann #1495
Merged
Remove internal flann #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servantftechnicolor
force-pushed
the
dev/externalFlann
branch
2 times, most recently
from
3c52c36 to
251ae68
Compare
servantftechnicolor
force-pushed
the
dev/externalFlann
branch
from
598cc8f to
21f55b1
Compare
cbentejac
previously approved these changes
Aug 1, 2023
simogasp
previously requested changes
Aug 1, 2023
There was a problem hiding this comment.
Don't forget to update the documentation, e.g.
https://github.com/alicevision/AliceVision/blob/develop/INSTALL.md#dependencies
https://github.com/alicevision/AliceVision/blob/develop/INSTALL.md#building-the-project-using-vcpkg-recommended-on-windows
https://github.com/alicevision/AliceVision/blob/develop/INSTALL.md#building-the-project-using-external-dependencies
Flann can now only be used as an external dependency hence the following updates: - It is removed from the list of internal dependencies, and the AV fork is linked instead; - It is explicitly added to the list of packages to install with vcpkg (in reality, it was already installed without being explicitly requested); - Any reference to Flann being either internal or external is removed.
cbentejac
dismissed
simogasp’s stale review
Done: the documentation has been updated.
cbentejac
approved these changes
Aug 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove flann located inside alicevision repository to use an external one.
Updated CMakeLists to use non modified lz4 and flann.
Disable PCL as it is not used in AliceVision currently.