Binary format type for ply IO #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2023 16:20
cbentejac
force-pushed
the
ply_io_binary_format
branch
from
297c654 to
df7fc43
Compare
cbentejac
previously approved these changes
Oct 26, 2023
|
Hi @Kokika, Thank you for your contribution! I rebased your branch on top of |
The CI on Windows fails with "error C2678: binary '|=': no operator found which takes a left-hand operand of type 'std::_Iosb<int>::_Openmode' (or there is no acceptable conversion) ".
cbentejac
force-pushed
the
ply_io_binary_format
branch
from
7f533f2 to
be8157f
Compare
cbentejac
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR writes binary PLY files instead of ASCII ones if
.bin.is detected in the name of the file to write.