[sfmData] Ensure copies of SfMData are deep instead of shallow

src/aliceVision/sfmData/HashMapPtr.hpp

@@ -10,10 +10,45 @@
 namespace aliceVision {
 namespace sfmData {
 
+template<class T>
+auto cloneT(T * ptr, int val) -> decltype(ptr->clone())
+{
+    if (ptr)
+    {
+        return ptr->clone();
+    }
+
+    return nullptr;
+}
+
+template<class T>
+T * cloneT(T * ptr, long val)
+{
+    if (ptr)
+    {
+        return new T(*ptr);
+    }
+
+    return nullptr;
+}
+
 template<class T>
 class HashMapPtr : public HashMap<IndexT, std::shared_ptr<T>>
 {
   public:
+    HashMapPtr<T>() : HashMap<IndexT, std::shared_ptr<T>>()
+    {
+
+    }
+
+    HashMapPtr(const HashMapPtr<T> & other)
+    {
+        for (const auto & pair : other)
+        {
+            this->insert({pair.first, std::shared_ptr<T>(cloneT(pair.second.get(), 0))});
+        }
+    }
+
     /**
      * We don't want the user to assume the object is created when the index does not exist in the map
      */

src/aliceVision/sfmData/SfMData.cpp

@@ -20,9 +20,6 @@ using namespace aliceVision::image;
 
 namespace fs = boost::filesystem;
 
-SfMData::SfMData() {}
-
-SfMData::~SfMData() {}
 
 bool SfMData::operator==(const SfMData& other) const
 {

src/aliceVision/sfmData/SfMData.hpp

@@ -70,9 +70,6 @@ class SfMData
     /// Rotation priors
     RotationPriors rotationpriors;
 
-    SfMData();
-    ~SfMData();
-
     // Operators
 
     bool operator==(const SfMData& other) const;