[mesh] texturing: performance optimization of image fusion #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contribution to multiple textures per image. It limits the number of images reloads from files. Around 3x speedup on a dataset of 250 images.
src/aliceVision/mesh/Texturing.cpp
Outdated
| { | ||
| accuImage.img[xyoffset] = accuImage.img[xyoffset-texParams.textureSide]; | ||
| } | ||
| accuImage.imgCount[xyoffset] += 1; |
There was a problem hiding this comment.
we should update imgCount only if we set img[xyoffset].
fabiencastan
requested changes
Mar 21, 2019
ToukL
reviewed
Mar 28, 2019
| size_t atlasID, mvsUtils::ImagesCache& imageCache, | ||
| /// Generate texture files for the given sub-set of texture atlases | ||
| void generateTexturesSubSet(const mvsUtils::MultiViewParams& mp, | ||
| std::vector<size_t> atlasIDs, mvsUtils::ImagesCache& imageCache, |
There was a problem hiding this comment.
Missing & for std::vector<size_t> atlasIDs.
…into dev_textureFusionPerImage Conflicts: src/aliceVision/mesh/Texturing.cpp
Create the texture padding with only two passes of the image instead of 2*padding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[X] Contribution to multiple textures per image. It limits the number of images reloads from files. Around 3x speedup on a dataset of 250 images.
[X] Texture padding speedup: Create the padding with only
2loops over the texture instead of2*paddingloops. So the performance cost does not depend on the size of the padding anymore. 28% speedup on a small dataset of 12 images. Of course, the speedup be smaller on large datasets as the largest part of the processing will be the image contributions.