[sfmDataIO] Alembic: use XForms instead of untyped objects for root n… #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odes There is no standard way to handle Alembic nodes without type information (OObject). Using OXForm guarantees that the generated Alembic file can be properly loaded in other applications, and with the correct hierarchy. This does not introduce compatibility issues: the AlembicImporter does not require root nodes to be untyped objects to parse an Alembic sfmData file.
simogasp
approved these changes
Jul 9, 2019
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes root nodes of Alembic SfmData file XForms instead of untyped objects. This ensures better interoperability with other 3D graphics applications, because there is no standard way to handle Alembic nodes without type information. This was, for example, resulting in potential crashes or incorrect hierarchies when importing our Alembic files into Blender.
Using XForms guarantees that the generated Alembic file can be properly loaded into other applications, and with the correct hierarchy:
Imported Alembic file in current Blender 2.8 beta after this fix
Fix alicevision/Meshroom#170 alicevision/Meshroom#460
Features list
Implementation remarks
This does not introduce compatibility issues: the AlembicImporter does not require root nodes to be untyped objects to parse an Alembic sfmData file.