Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Changes in the docker build command #760

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

vaghawan
Copy link
Contributor

Looks like the docker build command that was provided earlier should have been for the earlier version of Dockers, I'm using Docker version 19.03.8 and copying the above command doesn't work. Since in the newer version of docker, the --build-arg needs to be added separately for each param.

Description

Features list

Implementation remarks

Looks like the docker build command that was provided earlier should have been for the earlier version of Dockers, I'm using Docker version 19.03.8 and copying the above command doesn't work. Since in the newer version of docker, the --build-arg needs to be added separately for each param.
@fabiencastan
Copy link
Member

Thanks for the PR.
Could you update all the existing commands to use the new syntax everywhere?
There is no need to explain the difference as the new syntax is supported by previous versions, so we can just use a syntax which maximize compatibility.

@vaghawan
Copy link
Contributor Author

Thanks for the PR.
Could you update all the existing commands to use the new syntax everywhere?
There is no need to explain the difference as the new syntax is supported by previous versions, so we can just use a syntax which maximize compatibility.

Ya, Sure!

As pointed by @fabiencastan , I've updated the existing commands instead of adding new commands for docker build.
@simogasp simogasp added this to the 2020.1.0 milestone Mar 25, 2020
@fabiencastan fabiencastan merged commit 392855f into alicevision:develop Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants