Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[matching] build fix for MSVC 2019 #805

Merged
merged 1 commit into from
Jun 9, 2020
Merged

[matching] build fix for MSVC 2019 #805

merged 1 commit into from
Jun 9, 2020

Conversation

dsmtE
Copy link
Contributor

@dsmtE dsmtE commented Jun 9, 2020

Description

Fix #778

@dsmtE dsmtE added this to the 2020.1.0 milestone Jun 9, 2020
fabiencastan
fabiencastan previously approved these changes Jun 9, 2020
Copy link
Member

@simogasp simogasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Would you mind to fix those consts as well?

src/aliceVision/matching/kvld/kvld.cpp Outdated Show resolved Hide resolved
src/aliceVision/matching/kvld/algorithm.h Outdated Show resolved Hide resolved
src/aliceVision/matching/kvld/algorithm.h Outdated Show resolved Hide resolved
Update src/aliceVision/matching/kvld/kvld.cpp
Update src/aliceVision/matching/kvld/kvld.h
Update src/aliceVision/matching/kvld/algorithm.cpp
Update src/aliceVision/matching/kvld/algorithm.h

Co-authored-by: Simone Gasparini <[email protected]>
@simogasp simogasp merged commit 89db091 into develop Jun 9, 2020
@simogasp simogasp deleted the fix/msvc2019 branch June 9, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error C1001 (Internal compiler error) when compiling with CUDA 10 and VS 2019
3 participants