Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] ImageGallery: fix some minor issues #1766

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Conversation

cbentejac
Copy link
Contributor

Description

This PR fixes a couple minor UI issues with the Image Gallery:

  • the indexing of the groups that was displayed as starting at 0 instead of 1
  • the intrinsics table that was overlapping with the group label when there were enough intrinsics entries in the table

Additionally, it adds the automatic switch to the correct group when a user double-clicks on a CameraInit node in the graph.

Features list

  • Start the group indexing at 1 instead of 0
  • Prevent the intrinsics table from ever overlapping with the group label
  • When the user double-clicks on a CameraInit node, automatically switch to the corresponding group

The first group will not be displayed as "Group 0 / X" anymore,
but rather as "Group 1 / X".
…clicked

If a node of type "CameraInit" is double-clicked in the Graph Editor,
the Image Gallery group index will immediately be updated to display
the corresponding node's information.
@fabiencastan fabiencastan added this to the Meshroom 2022.1.0 milestone Sep 5, 2022
@fabiencastan fabiencastan merged commit aa1edf8 into develop Sep 5, 2022
@fabiencastan fabiencastan deleted the fix/uiImageGallery branch September 5, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants