-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Add cgroups support to meshroom #1836
Conversation
We need to find a way for nodes to declare if they supports these arguments or rely on environment variables. |
we could use a chunk.node.nodeDesc.commandLine.startswith("aliceVision_") to do this only on the proper nodes |
a warning in the log when the feature is used may be usefull |
5c72a25
to
ae0ca71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on windows, no effect (as expected).
Note: the class solution changes the uid of the nodes, this forces to recompute projects.
CGroups on linux may limit the memory and the number of cpus
Without getting the specific information about these limits, we may overshoot our memory usage and core usage, creating crashes.
This PR will read the values as specified by the specifications.
Rely on alicevision/AliceVision#1304.