[core] Correctly parse status in version names when it exists #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
reviewed
Apr 7, 2023
Version objects were meant to be used only with numerical characters,
separated by periods. Now that the version of Meshroom can also contain
its status ("develop" when it is in develop mode), the Version class
needs to be able to parse the status string as well as the version
components when it exists.
The status is handled as a separate string, which is returned in addition
to the tuple of integers when the whole version string is parsed in the
first place.
This prevents issues when opening files that have been saved with a version
like "x.x.x-develop".
cbentejac
force-pushed
the
fix/projectVersions
branch
from
638d140 to
0b4e38f
Compare
fabiencastan
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Versionobjects were meant to be used only with numerical characters, separated by periods. Now that the version of Meshroom can also contain its status ("develop" when it is in develop mode), theVersionclass needs to be able to parse the status string (when it exists) as well as the version components.This PR addresses this by handling the status as a separate string, which is returned in addition to the tuple of integers when the whole version string is parsed in the first place.
This prevents issues when opening files that have been saved with a version like "x.x.x-develop".