Header change detection construct #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOrangePuff
requested review from
toddhainsworth,
aaronmedina-dev and
AdamJHall
|
The build is failing for a strange reason 🤔 |
AdamJHall
reviewed
Jan 22, 2025
packages/header-change-detection/lib/header-change-detection.ts
Outdated
Show resolved
Hide resolved
toddhainsworth
requested changes
Jan 22, 2025
| const securityHeaders = HEADERS?.split(",") || [] | ||
|
|
||
| type Headers = Map<string, string | undefined> | ||
| type URLHeaders = Map<string, Headers> |
There was a problem hiding this comment.
I'm wondering if commentary describing what the string key is here (the URL, right?) might make it clearer?
AdamJHall
previously approved these changes
Jan 23, 2025
TheOrangePuff
dismissed stale reviews from AdamJHall and toddhainsworth
via
83307c7
toddhainsworth
previously approved these changes
Jan 24, 2025
TheOrangePuff
force-pushed
the
feature/header-change-detection
branch
from
83307c7 to
3e74aae
Compare
AdamJHall
approved these changes
Jan 24, 2025
toddhainsworth
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
This is a big PR, apologies. Probably best to read the readme which describes the purpose of what I'm adding here. TL;DR: this is required for PCI DSS v4 11.6.1.
This creates a Lambda, DynamoDB table, and EventBridge schedule to check for header changes. The idea is that this construct can be added to any hosting stack to add the header change detection functionality.
Notes to reviewers
@toddhainsworth I've added you specifically for the Lambda function code review but feel free to review other areas as well.
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback