Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file not found error with latest dotnet 6.0.2 and pack issue #2

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

Kurounin
Copy link

No description provided.

@Kurounin
Copy link
Author

@alirezanet Can you please merge this and make a new release? It fixes 2 issues I encountered:

@alirezanet alirezanet merged commit 2d8248d into alirezanet:master Mar 11, 2022
@alirezanet
Copy link
Owner

alirezanet commented Mar 11, 2022

Sure thanks. 👌

@FabianTerhorst
Copy link

Since this change i have a problem publishing a C# CodeGen Package.
https://github.com/FabianTerhorst/coreclr-module/runs/5523504770?check_suite_focus=true
With 3.0.0 it works.

@alirezanet
Copy link
Owner

Since this change i have a problem publishing a C# CodeGen Package. https://github.com/FabianTerhorst/coreclr-module/runs/5523504770?check_suite_focus=true With 3.0.0 it works.

Yeah, Looks like this PR have added more issues, I've had a few problems too
Until we fix this, use the v3.0.0.

@Kurounin
Copy link
Author

Kurounin commented Mar 14, 2022

Sorry about that. For my nugets (using latest dotnet 6.x) it works fine.
@FabianTerhorst seems that dotnet pack fails to build properly.

@alirezanet since my issue was that running build before pack was missing some dlls in the nuget, maybe an extra flag SKIP_BUILD which by default would be false (so it doesn't break existing actions) would solve this? I just tested on my project that had the issue and keeping the dotnet build step and after running dotnet pack is a viable solution as well as long as it doesn't contain the flag --no build. The pack time is the same since it determines that All projects are up-to-date for restore.

@Kurounin
Copy link
Author

I created a new PR with the fix #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants