Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Changes to do with primary particle definition as implemented" #332

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Revert "Changes to do with primary particle definition as implemented" #332

merged 1 commit into from
Jul 21, 2017

Conversation

pzhristov
Copy link
Collaborator

Reverts #271

After some investigations it seems that this pull request does not behave according to the expectations and creates problems with EPOS, pythia, etc. Following a request from the physics coordination I am reverting it temporarily.

@pzhristov
Copy link
Collaborator Author

+test

@alibuild
Copy link
Collaborator

0120583: testing approved: will not be automatically merged; starting testing. If testing succeeds, merging will require further approval from 1 of @jgrosseo (Jan Fiete Grosse-Oetringhaus), @chiarazampolli (Chiara Zampolli), @qgp (Jochen Klein), @dberzano (Dario Berzano), @sawenzel (Sandro Christian Wenzel), @ktf (Giulio Eulisse), @shahor02 (Ruben Shahoyan)

@alibuild
Copy link
Collaborator

0120583: tests OK, approval required for merging: 1 of @jgrosseo (Jan Fiete Grosse-Oetringhaus), @chiarazampolli (Chiara Zampolli), @qgp (Jochen Klein), @dberzano (Dario Berzano), @sawenzel (Sandro Christian Wenzel), @ktf (Giulio Eulisse), @shahor02 (Ruben Shahoyan)

Comment with +1 to merge. Please comment on the pull request: click here and comment at the bottom of the page.

@pzhristov
Copy link
Collaborator Author

+1

@alibuild alibuild merged commit f322190 into alisw:master Jul 21, 2017
@dberzano
Copy link
Contributor

Given the impact I'd say we immediately start the validation for the new tag.

dberzano pushed a commit to dberzano/ali-bot that referenced this pull request Jul 27, 2017
Analysis tags depending on v5-09-10 and v5-09-11 have to be removed as per
the Physics Board decision. See alisw/AliRoot#332.
dberzano pushed a commit to dberzano/ali-bot that referenced this pull request Jul 27, 2017
Analysis tags depending on v5-09-10 and v5-09-11 have to be removed as per
the Physics Board decision. See alisw/AliRoot#332.
dberzano added a commit to alisw/ali-bot that referenced this pull request Jul 27, 2017
Analysis tags depending on v5-09-10 and v5-09-11 have to be removed as per
the Physics Board decision. See alisw/AliRoot#332.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants