Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only get userAgent when needed #124

Closed
wants to merge 1 commit into from
Closed

Only get userAgent when needed #124

wants to merge 1 commit into from

Conversation

tyrannosaurus-becks
Copy link

The Go SDK is used by Hashicorp for Vault, and it retrieves information from the external environment on package initialization that won't necessarily be needed. This PR moves the call out of package initialization while retaining all normal functionality.

See hashicorp/vault#5324 for more.

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage decreased (-50.7%) to 40.567% when pulling fd883d8 on tyrannosaurus-becks:only-get-system-info-if-needed into 36bf7aa on aliyun:master.

@hangzws
Copy link
Collaborator

hangzws commented Sep 18, 2018

Thanks for you pr, we will merge it in master later.

@tyrannosaurus-becks
Copy link
Author

@hangzws thank you!

Do you currently have any idea of the date on which it will be merged into master? We are deciding whether to use a forked version of this repo for our 0.11.2 release of Vault.

@hangzws
Copy link
Collaborator

hangzws commented Dec 3, 2018

we will fix it in version 1.9.3

@tyrannosaurus-becks
Copy link
Author

@hangzws thank you!

@hangzws hangzws closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants