fix: add common error handling for missing or wrong username #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdahuja
commented
Feb 23, 2019
Berkmann18
reviewed
Feb 23, 2019
Berkmann18
requested changes
Feb 23, 2019
There was a problem hiding this comment.
Make sure you follow the Angular commit convention as explained in the contribution guidelines.
Okay, thanks. I'll rebase and update once review process is completed. I think it's done now. since my doubt is resolved. Thanks! |
erdahuja
commented
Feb 25, 2019
src/repo/__tests__/github.js
Outdated
| @@ -65,6 +65,10 @@ test('handle errors', async () => { | |||
| await rejects(getUserInfo('nodisplayname')) | |||
| }) | |||
|
|
|||
| test('Throw error when no username is provided', () => { | |||
| expect(getUserInfo).toThrow('No login when adding a contributor. Please specify a username.') | |||
There was a problem hiding this comment.
@sinchang I did it like this. Re read documentation. Actually expect should call the function not us.
There was a problem hiding this comment.
@Berkmann18 friendly ping
erdahuja
changed the title
erdahuja
force-pushed
the
issue-170
branch
2 times, most recently
from
28c933e to
c9a470b
Compare
Berkmann18
approved these changes
Mar 6, 2019
sinchang
approved these changes
Mar 17, 2019
|
🎉 This PR is included in version 6.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
issue #6
Why:
How:
Checklist: