On adding non existent github user name, error shown is not descriptive. #170
Comments
|
Thanks for reporting that, what error message would you expect in the above scenario? |
|
I checked the code throws a common error for not found cases. This is very confusing for end users and non informative. let me try adding some value here. |
|
@Berkmann18 I have fixed it, how to add a PR? i dont have permissions. My email id - [email protected] |
|
@erdahuja you can see this tutorial http://makeapullrequest.com/ |
erdahuja
added a commit
to erdahuja/all-contributors-cli
that referenced
this issue
Feb 23, 2019
erdahuja
added a commit
to erdahuja/all-contributors-cli
that referenced
this issue
Feb 25, 2019
erdahuja
added a commit
to erdahuja/all-contributors-cli
that referenced
this issue
Feb 25, 2019
erdahuja
added a commit
to erdahuja/all-contributors-cli
that referenced
this issue
Feb 25, 2019
# This is the 1st commit message: fix:all-contributors#6 added common error handling for username not provided or wrong username provided. # This is the commit message all-contributors#2: fix:all-contributors#170 added tests for no username case in github getInfo api. # This is the commit message all-contributors#3: fix:all-contributors#170 added tests for no username case in github getInfo api.
|
@erdahuja how's it going? Is there anything we can help with |
|
@jakebolam @sinchang Please merge my PR it's completed with tests, also approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
all-contributors-cliversion:nodeversion:npm(oryarn) version:Relevant code or config
What you did:
added non github username contributor.
What happened:
Reproduction repository:
Simply run cli tool "yarn run all-contributors" and answer question 1 with wrong username.
Problem description:
Suggested solution:
A better error message
The text was updated successfully, but these errors were encountered: