Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RW-4091][RISK=NO]Change the return object for cloud task to array of long #3043

Merged
merged 3 commits into from
Jan 28, 2020

Conversation

NehaBroad
Copy link
Collaborator

@NehaBroad NehaBroad commented Jan 27, 2020

The request body for cloud task was set to Object just so RDR is unblocked and we can start export data. This PR is replacing generic Object to Array of Long


PR checklist

  • [ X] This PR meets the Acceptance Criteria in the JIRA story
  • [ X] The JIRA story has been moved to Dev Review
  • This PR includes appropriate unit tests
  • [ X] I have run and tested this change locally
  • [ X] If this includes an API change, I have updated the appropriate Swagger definitions and notified API consumers
  • If this includes a new feature flag, I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later

Copy link
Collaborator

@jmthibault79 jmthibault79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you need to update OfflineRdrExportController or will it work as-is?

@NehaBroad
Copy link
Collaborator Author

Will you need to update OfflineRdrExportController or will it work as-is?
OfflineRdrExportController will work as is, its still sending List as JSON

@NehaBroad NehaBroad merged commit db2f1f4 into master Jan 28, 2020
@NehaBroad NehaBroad deleted the nsaxena/RDR/swagger branch January 28, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants