Fix action description adn error appearing when it shouldn't

allegro · Mar 4, 2025 · 3b79521 · 3b79521
1 parent 9d8a37d
commit 3b79521
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/ralph/data_center/admin.py b/src/ralph/data_center/admin.py
@@ -555,6 +555,7 @@ class DataCenterAssetAdmin(
     def assign_mgmt_hostname(self, *args, **kwargs):
         return assign_management_hostname_and_ip(self, *args, **kwargs)
 
+    assign_mgmt_hostname.short_description = "Assign management hostname and IP"
     def get_export_queryset(self, request):
         qs = (
             super(RalphAdminImportExportMixin, self)

diff --git a/src/ralph/data_center/admin_actions.py b/src/ralph/data_center/admin_actions.py
@@ -30,6 +30,7 @@ def assign_management_hostname_and_ip(modeladmin, request, queryset):
                 modeladmin.message_user(
                     request, f"Updated management hostname for asset id: {dca.id}", level="INFO"
                 )
+                continue
             else:
                 ip = _infer_ip(dca, rack_number)  # others (i.e. server rack)
                 if ip:
@@ -39,6 +40,7 @@ def assign_management_hostname_and_ip(modeladmin, request, queryset):
                         request,
                         f"Updated management hostname and IP for asset id: {dca.id}", level="INFO"
                     )
+                    continue
             raise RuntimeError("unknown error")
         except Exception as e:  # noqa
             modeladmin.message_user(request, f"Can't update asset id: {dca.id}: {e}", level="ERROR")