Add auto hostname #3884
Merged
Add auto hostname #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipek8
commented
Mar 3, 2025
Comment on lines
+576
to
+578
| def assign_mgmt_hostname(self, *args, **kwargs): | ||
| return assign_management_hostname_and_ip(self, *args, **kwargs) | ||
|
|
There was a problem hiding this comment.
This is weird but for a reason - if I added original action directly to actions list the the tests wouldn't work.
So if I did
actions = ["bulk_edit_action", "invoice_report", assign_management_hostname_and_ip]
I wouldn't be able to call
admin.assign_management_hostname_and_ip [...]
Weird but hope it is fixed in some future django version
hipek8
commented
Mar 3, 2025
Comment on lines
+12
to
+13
| if not modeladmin.has_change_permission(request, obj=dca): | ||
| raise RuntimeError("insufficient permissions") |
There was a problem hiding this comment.
Because of mess with actions this action is visible for everyone so I guard here
matyldv
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.