run tests on Beaker with NFS cache #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
commented
Feb 18, 2023
Comment on lines
+13
to
+21
| # These are tasks are known to fail for now due to an unreachable server. | ||
| known_failures = { | ||
| "lambada_mt_en", | ||
| "lambada_mt_fr", | ||
| "lambada_mt_de", | ||
| "lambada_mt_it", | ||
| "lambada_mt_es", | ||
| "triviaqa", | ||
| } |
There was a problem hiding this comment.
I had to xfail these tests because the server they rely on is apparently down. @dirkgr you might want to look into this more, maybe there's a new URL we should be using.
There was a problem hiding this comment.
Hmm. Once they are cached, we are much more robust to such failures.
dirkgr
approved these changes
Feb 18, 2023
Comment on lines
+81
to
+92
| test_suite: | ||
| - name: A | ||
| mark: "not suite_B and not suite_C and not suite_D" | ||
|
|
||
| - name: B | ||
| mark: "suite_B" | ||
|
|
||
| - name: C | ||
| mark: "suite_C" | ||
|
|
||
| - name: D | ||
| mark: "suite_D" |
There was a problem hiding this comment.
What is this for? More parallelism?
There was a problem hiding this comment.
Yea, as I mentioned in the description I broke the tests up into arbitrary groups aka "suites".
Comment on lines
+13
to
+21
| # These are tasks are known to fail for now due to an unreachable server. | ||
| known_failures = { | ||
| "lambada_mt_en", | ||
| "lambada_mt_fr", | ||
| "lambada_mt_de", | ||
| "lambada_mt_it", | ||
| "lambada_mt_es", | ||
| "triviaqa", | ||
| } |
There was a problem hiding this comment.
Hmm. Once they are cached, we are much more robust to such failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
beaker-run-action(this is what we use to run GPU tests on Beaker for Tango).Once https://github.com/allenai/reconfig/issues/1166 is resolved we should update the cache location.