Merge pull request #205 from alleyinteractive/feature/display-name-tests

Adding tests for the `get_the_author_display_name` functionality
alleyinteractive · Nov 16, 2023 · 044ef42 · 044ef42
2 parents 1b759b8 + 6bd4cd5
commit 044ef42
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/inc/core-filters.php b/inc/core-filters.php
@@ -30,7 +30,6 @@ function auto_integrate_byline( $author_name ): string {
 	return get_the_byline();
 }
 add_filter( 'the_author', __NAMESPACE__ . '\auto_integrate_byline' );
-add_filter( 'get_the_author_display_name', __NAMESPACE__ . '\auto_integrate_byline' );
 
 /**
  * Automatically integrate the byline into the `the_author_posts_link` filter.

diff --git a/tests/feature/test-core-filters.php b/tests/feature/test-core-filters.php
@@ -240,4 +240,22 @@ public function test_author_link() {
 			get_author_posts_url( $post->post_author )
 		);
 	}
+
+	public function test_get_author_display_name_from_user(): void {
+		$author_name = 'Dumas Davy de la Pailleterie';
+		$user        = static::factory()->user->create_and_get(
+			[
+				'display_name' => $author_name,
+				'first_name'   => 'Dumas',
+				'last_name'    => 'Davy de la Pailleterie',
+			]
+		);
+
+		static::factory()->post->create_and_get( [ 'post_author' => $user->ID ] );
+
+		$display_name = get_the_author_meta( 'display_name', $user->ID );
+
+		$this->assertNotSame( '', $display_name );
+		$this->assertSame( $author_name, $display_name );
+	}
 }