Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-15: Add GitHub Actions for Testing This Repo #111

Merged
merged 9 commits into from
Dec 13, 2024

Conversation

benpbolton
Copy link
Member

@benpbolton benpbolton commented Dec 11, 2024

Summary

This pull request introduces GitHub Actions to ensure that changes to create-wordpress-plugin and create-wordpress-theme do not break this project. It aims to address the user story and acceptance criteria outlined in the GitHub issue to resolve #15 .

Changes

  • Added a new GitHub Action workflow file that runs checks on PRs and on a schedule.
  • Configured the workflow to use an automatic installation script to emulate user behavior (selecting all defaults for now) for project configuration.

Notes for reviewers

  • GitHub Action should be triggered on PR creation and scheduled weekly
  • While the GitHub Action successfully configures the project using the automatic installation script and runs through a 'default' installation, there are several discovered issues (created phpcs and phpunit are not running from the project 'root' #114 for reference):
    • phpcs isn't running from the root (composer.json suggests going into the plugin directory to run, but these should run from root)
    • phpunit isn't running from the root (same deal as above)

... as such, the tests will be failing but we intend to ship this with failing tests and create any necessary follow-up issues to address.

Additional Notes

Per the discussion in the issue comments, testing against both VIP-type and Pantheon-type repos was considered challenging due to the current state of the configure.php script. The decision was made to focus on testing with default options to progress with the implementation of this feature.

@benpbolton benpbolton marked this pull request as ready for review December 12, 2024 14:26
@benpbolton benpbolton requested a review from a team as a code owner December 12, 2024 14:26
@benpbolton benpbolton merged commit 5e8e18f into develop Dec 13, 2024
1 check failed
@benpbolton benpbolton deleted the feature/issue-15/add-github-actions-for-testing branch December 13, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Actions for Testing This Repo
2 participants