Fix PHPStan Paths for WordPress VIP #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I understand correctly, you're wondering why we're only scanning specific files in mu-plugins, right? That's because we only want to scan files that we control. If we would add a third party mu-plugin (either a directory of a file) we wouldn't want to scan it because it might not conform to our standards. That would be the case if we added Pantheon's mu-plugin or if we included one of VIP's helpers or plugins. |
|
The test failures here are unrelated, and stem from this issue: #114 |
srtfisher
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97
I ran the configure script locally, created a VIP project, ran PHPStan with my changes here, and all passed :)