Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-10: Add Buddy PR Checks #76

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Issue-10: Add Buddy PR Checks #76

merged 5 commits into from
Mar 12, 2024

Conversation

kevinfodness
Copy link
Member

Description

Add a configuration for PR checks using Buddy, which performs the following checks against an assumed plugin and theme:

  • gitignored files check (ensure files that should be ignored are not committed)
  • git conflict markers check (ensure merge conflicts aren't committed)
  • phpcs
  • phpstan
  • phpunit
  • npm build
  • lint (includes ESLint, StyleLint, TypeScript typechecking)
  • JS tests using jest

Use Case

When a user uses this repository to build a project, they should be able to automate PR checks using Buddy.

@kevinfodness kevinfodness marked this pull request as ready for review March 8, 2024 20:24
@kevinfodness kevinfodness requested a review from a team as a code owner March 8, 2024 20:24
efuller
efuller approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@efuller efuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ Learned some things about Buddy!

kaitlinbolling
kaitlinbolling approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@kaitlinbolling kaitlinbolling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! Just one question.

.npmrc Show resolved Hide resolved
@kevinfodness kevinfodness merged commit 6919263 into develop Mar 12, 2024
@kevinfodness kevinfodness deleted the feature/issue-10/add-buddy-pr-checks branch March 12, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efuller efuller efuller approved these changes

@kaitlinbolling kaitlinbolling kaitlinbolling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinfodness @kaitlinbolling @efuller