Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-159: Fatal on front end when trending is set as source but parsely not setup #160

Merged

Conversation

mogmarsh
Copy link
Collaborator

@mogmarsh mogmarsh commented Mar 27, 2024

Fixes Issue

#159 - Fatal on front end when trending is set as source but parsely not setup

I will add the version bump and changelog shortly.

Description of the Change

  • Viewing a Query block that has trending set for the source results in an error on the front end if parsely is not set up.

Steps To Reproduce

  1. Set up a Query block and in the code view set orderby to trending
<!-- wp:wp-curate/query {"deduplication":"never","numberOfPosts":4,"posts":[null,null,null,null],"orderby":"trending"} -->
<div class="wp-block-wp-curate-query"><!-- wp:post-template -->
<!-- wp:wp-curate/post -->
<div class="wp-block-wp-curate-post"><!-- wp:columns {"isStackedOnMobile":false} -->
<div class="wp-block-columns is-not-stacked-on-mobile"><!-- wp:column {"width":"60%"} -->
<div class="wp-block-column" style="flex-basis:60%"><!-- wp:post-title {"level":3,"isLink":true} /-->

<!-- wp:group {"style":{"spacing":{"blockGap":"0"}},"layout":{"type":"flex","flexWrap":"wrap"}} -->
<div class="wp-block-group"><!-- wp:post-date {"format":"M j, Y g:i A", "timediff": true} /-->

<!-- wp:mediaco/primary-term {"isLink":false} /--></div>
<!-- /wp:group --></div>
<!-- /wp:column -->

<!-- wp:column {"width":"40%"} -->
<div class="wp-block-column" style="flex-basis:40%"><!-- wp:post-featured-image {"isLink":true,"aspectRatio":"16/9","style":{"layout":{"selfStretch":"fixed","flexSize":"50%"}}} /--></div>
<!-- /wp:column --></div>
<!-- /wp:columns --></div>
<!-- /wp:wp-curate/post -->
<!-- /wp:post-template --></div>
<!-- /wp:wp-curate/query -->
  1. Make sure parsely is not configured.
  2. View it on the front end.

Additional Information

No response

@mogmarsh mogmarsh marked this pull request as ready for review March 27, 2024 15:27
Copy link
Member

@attackant attackant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐙

src/features/class-parsely-support.php Show resolved Hide resolved
@mogmarsh mogmarsh enabled auto-merge March 27, 2024 16:28
@mogmarsh mogmarsh merged commit 80e4c2c into develop Mar 27, 2024
7 checks passed
@mogmarsh mogmarsh deleted the fix/issue-159/fatal-frontend-trending-no-parsely-setup branch March 27, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants