Issue-216: Pinned posts that are deleted or unpublished cause problems in editor and on graphql front end #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he post has been deleted or unpublished
efuller
approved these changes
Aug 19, 2024
| @@ -118,7 +121,7 @@ export function mainDedupe() { | |||
| } | |||
|
|
|||
| // Loop through all query blocks and set backfilled posts in the open slots. | |||
| queryBlocks.forEach((queryBlock) => { | |||
| queryBlocks.forEach(async (queryBlock) => { | |||
There was a problem hiding this comment.
While this code does look to work, eventually we will want to refactor the usage of an async callback here. Some recommendations call for use of a for...of loop but it can largely depend on what other functionality we have going on here.
mogmarsh
deleted the
fix/issue-216/pinned-posts-deletion-unpublish-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #216 - This pull request addresses the issue where pinned posts that are deleted or unpublished cause problems in the editor and on the graphql front end.
Description
If a pinned post is deleted or unpublished, it causes issues in the editor (you can't tell that the post has been pinned) and on the front end in graphql. The solution now includes showing an error in the editor when a pinned post is deleted or unpublished and removing the post's ID from the graphql front end to prevent errors.
Steps To Reproduce
Additional Information
No response