Feature: Issue-218: Cache Initial Post API Calls #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This essentially turns of default automatic revalidations
dlh01
reviewed
Aug 21, 2024
| @@ -1,4 +1,5 @@ | |||
| /* eslint-disable camelcase */ | |||
| import useSWRImmutable from 'swr/immutable'; | |||
There was a problem hiding this comment.
@efuller Does disabling automatic revalidation eliminate the need for workarounds like this one? https://l.alley.dev/ca8db44a8f
There was a problem hiding this comment.
@dlh01 I think it could. useSWRImmutable will simply just cache an API call and unless that request changes in any way, it will continue to use the cache.
The use case I wanted to guard against was the revalidation after switching tabs. Here are some docs on revalidation and there are a ton of additional options as well.
I think it could be worth a try!
…l-query-api-calls # Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces
SWRwhich will help to cache API responses that are identical calls. TheuseSWRImmutablehook is used so that automatic revalidation is not turned on.Reviewer Notes
Will bump version after CR.
Description
When loading a page in the editor that is powered by the query block, there are several API calls to the API for gathering the posts needed. Many of these API calls are the same. Find a way to increase performance by minimizing the number of API calls upon load.
Testing
Before merging in, it would be great to get another set of 👀 on actual testing in the editor.
Ticket
Fixes #218