-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
block_number_index added to callBundle reference type #1705
Conversation
One thing to note, there are 2 options naming wise, which likely have implications on the implementation Don't have a strong opinion on which is better Option 1
Option 2
This requires you to update the state_block_number to be the same as the block_number and include all 3 fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is just an extra setting, this should be fine
Just updated the imports for TransactionIndex |
Motivation
Ability to quickly identify via an API call why a bundle did not land
paradigmxyz/reth#12353
Solution
Allow callBundle simulations to occur from a block index rather than a state_block_number, if a bundle has a target transaction that lands in block x this enables you to simulate from the exact index in block x where the target transaction landed to see if there were transactions higher in the block that caused a state conflict.
PR Checklist