Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix SignableTransaction docs to use PrimitiveSignature #1743

Merged
merged 2 commits into from
Dec 3, 2024
Merged

docs: Fix SignableTransaction docs to use PrimitiveSignature #1743

merged 2 commits into from
Dec 3, 2024

Conversation

moricho
Copy link
Contributor

@moricho moricho commented Dec 3, 2024 •
edited
Loading

Motivation

Signature is being migrated to PrimitiveSignature and all alloy code now uses the latter
from: alloy-rs/core#788

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mattsse
Copy link
Member

mattsse commented Dec 3, 2024

needs rustfmt

@moricho
Copy link
Contributor Author

moricho commented Dec 3, 2024

thanks, fixed: ca722c2

@mattsse mattsse merged commit cc7d618 into alloy-rs:main Dec 3, 2024
26 checks passed
@moricho moricho deleted the fix-signable-tx-doc branch December 14, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moricho @mattsse