Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify host and port parameters for serve goal #53

Merged
merged 1 commit into from
Feb 11, 2018
Merged

Add ability to specify host and port parameters for serve goal #53

merged 1 commit into from
Feb 11, 2018

Conversation

baranoff-ivan
Copy link
Contributor

//: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)

Context

Allure commandline supports --port option for serve command and will also support --host option #662. But allure maven plugin does not support corresponding parameters. In this pull request I added servePort and serveHost parameters to plugin.
If this parameters are not specified functionality stays the same.

Checklist

@baev baev merged commit 357bfb2 into allure-framework:master Feb 11, 2018
@baev
Copy link
Member

baev commented Feb 11, 2018

@baranoff-ivan thanks!

PS sorry for the delay.

@chamithchathuka
Copy link

@baranoff-ivan @baev
I am running the server with
mvn io.qameta.allure:allure-maven:serve
command how can I add a parameter to the request

@svs-sp
Copy link

svs-sp commented Nov 1, 2022

@baranoff-ivan @baev
Hello. help me please
mvn io.qameta.allure:allure-maven:serve
Нow can I add a parameter to the request?

@baev
Copy link
Member

baev commented Nov 1, 2022

please do not comment on closed issues. No one will ever response here. For questions use stack overflow (tag allure) or create a discussion here https://github.com/orgs/allure-framework/discussions/categories/q-a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants