Skip to content
This repository has been archived by the owner on Jan 14, 2019. It is now read-only.

Stacktraces should use font with the same width for all chars #282

Closed
bazabaza opened this issue Jun 20, 2014 · 10 comments
Closed

Stacktraces should use font with the same width for all chars #282

bazabaza opened this issue Jun 20, 2014 · 10 comments
Milestone

Comments

@bazabaza
Copy link

I meen this stacktrace:
stacktrace

Difficult to read code with such font.
Seems to be better to use something like:
shouldbe

@baev
Copy link
Member

baev commented Jun 20, 2014

@bazabaza can you propose font you like?

@baev
Copy link
Member

baev commented Jun 20, 2014

@lanwen any thoughts?

@bazabaza
Copy link
Author

I tried to select font family on the second screen.
This style is already used in Allure.

Sorry, not as text.

@lanwen
Copy link
Contributor

lanwen commented Jun 21, 2014

@bazabaza please, provide same screen of assertion with changed font-family (it can be done in firebug). I've tryed to do it myself - but the result was unsatisfactory (it was less readable)

@bazabaza
Copy link
Author

@lanwen, I'll try to create a such screen on monday.
As one of variants - add link-button to open stacktrace in raw format.
It seems to me the same is present for txt attaches.

@bazabaza
Copy link
Author

@lanwen screen:
font-console

It looks better as for me.
Also the default width of panel with stacktrace (and other attachments) is rather narrow.
Maybe it's better to apply auto-width for it with some max width.
Or maybe just add "View raw" link as I wrote in previous comment.

@lanwen
Copy link
Contributor

lanwen commented Jun 24, 2014

Summoning designer @just-boris . Think we need raw btn - it will be helpful when we do markdown support. How difficult to create such btn?

@just-boris
Copy link
Contributor

it is easy. We need just add/remove class named something like "raw" to enable and disable view with monospace font

@vania-pooh vania-pooh added this to the 1.4.* milestone Jul 3, 2014
@vania-pooh vania-pooh changed the title Stacktraces shoud use font with the same width for all chars Stacktraces should use font with the same width for all chars Jul 17, 2014
@baev
Copy link
Member

baev commented Sep 3, 2014

@just-boris can you spend some time for this improvement?

@just-boris
Copy link
Contributor

@baev do it yourself

@vania-pooh vania-pooh modified the milestones: 1.4.1, 1.4.* Sep 3, 2014
baev added a commit that referenced this issue Sep 8, 2014
Added monospace toggle capability (fixes #282)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants