Skip to content
This repository has been archived by the owner on Jan 14, 2019. It is now read-only.

pie chart: percentage precision is 2 to postpone "100% passed" issue #827

Merged
merged 1 commit into from
Jul 25, 2016

Conversation

volkovs
Copy link
Contributor

@volkovs volkovs commented Jul 4, 2016

This is already fixed in master. But (since we have to support our Allure plugins for transition period) we would like to have it in 1.4.x branch as well.

Before:
100_passed

After:
1_failed

@just-boris
Copy link
Contributor

@volkovs I just wondering: why are you still using this branch?

1.4.24 seems usable enough and doesn't require so much efforts to upgrade.

@volkovs
Copy link
Contributor Author

volkovs commented Jul 4, 2016

@just-boris please correct me if I am wrong, but 1.4.24-SNAPSHOT in master branch has new face -> client side of allure plugins (I mean custom ones) is not backward compatible.

@just-boris
Copy link
Contributor

All changes in Java part were rolled back, so now new face is a drop-in replacement.

@just-boris
Copy link
Contributor

Even more, I got the bug report about number rounding and fixed it there several weeks ago

@volkovs
Copy link
Contributor Author

volkovs commented Jul 11, 2016

@just-boris Yes, exactly, I was "cherry-picking" it from your commit. The issue is that new face is a breaking change for custom plugin providers.

So, we hope you might release 1.4.x branch with this fix (before we rewrite our plugins for new face).

@just-boris
Copy link
Contributor

@volkovs thanks for the explanation, then it really needs to be merged.

Hope @baev will do this, when he will get an access to internet

@volkovs
Copy link
Contributor Author

volkovs commented Jul 25, 2016

@baev Hi, do you think you could release 1.4.x branch (old face) with this fix?

@baev
Copy link
Member

baev commented Jul 25, 2016

@volkovs oh, sorry, kinda forget about it. I'll fix this ASAP

@baev
Copy link
Member

baev commented Jul 25, 2016

test this please

@qatools-ci
Copy link
Contributor

SonarQube analysis reported 3 issues:

  • MAJOR 2 major
  • MINOR 1 minor

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

@baev baev merged commit bd1590c into allure-framework:1.4.x Jul 25, 2016
@volkovs
Copy link
Contributor Author

volkovs commented Jul 25, 2016

@baev No hurry. Take your time. Thanks.

@baev
Copy link
Member

baev commented Jul 25, 2016

@volkovs
Copy link
Contributor Author

volkovs commented Jul 27, 2016

@baev thank you very much

@volkovs volkovs deleted the 100 branch July 27, 2016 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants