-
Notifications
You must be signed in to change notification settings - Fork 167
pie chart: percentage precision is 2 to postpone "100% passed" issue #827
Conversation
@volkovs I just wondering: why are you still using this branch? 1.4.24 seems usable enough and doesn't require so much efforts to upgrade. |
@just-boris please correct me if I am wrong, but 1.4.24-SNAPSHOT in master branch has new face -> client side of allure plugins (I mean custom ones) is not backward compatible. |
All changes in Java part were rolled back, so now new face is a drop-in replacement. |
Even more, I got the bug report about number rounding and fixed it there several weeks ago |
@just-boris Yes, exactly, I was "cherry-picking" it from your commit. The issue is that new face is a breaking change for custom plugin providers. So, we hope you might release 1.4.x branch with this fix (before we rewrite our plugins for new face). |
@baev Hi, do you think you could release 1.4.x branch (old face) with this fix? |
@volkovs oh, sorry, kinda forget about it. I'll fix this ASAP |
test this please |
SonarQube analysis reported 3 issues: Watch the comments in this conversation to review them. |
@baev No hurry. Take your time. Thanks. |
@baev thank you very much |
This is already fixed in master. But (since we have to support our Allure plugins for transition period) we would like to have it in 1.4.x branch as well.
Before:
After: