Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add row group serialization #506

Merged

Conversation

piiertho
Copy link
Contributor

@piiertho piiertho commented Apr 30, 2024

At my company we need to have more granularity regarding serialization and deserialization of row groups.
We use pools of objects to avoid instantiations and we multi-thread modifications of objects in those pools and parquet row group writing using DoubleBuffer (which use the mentionned pools).
This way we have fast and memory efficient parquet jobs.

We were using version 3 of this nuget, using reflection to access private methods of ClrBridge class to get fast and memory efficient serialization.
As serialization API implementation changed a lot, we cannot achieve the same on version 4.
So here is our contribution.

This adds a method to serialize a collection into a single row group.
This adds methods to deserialize a single row group into an existing collection.
This adds methods to deserialize row group per row group using IAsyncEnumerable.

@piiertho
Copy link
Contributor Author

Checks are not passing on macOS because GitHub changed their runners to silicon. Setting a fixed runner version should fix this.

@piiertho piiertho force-pushed the feature/add-row-group-serialization branch from fa96616 to 6fc2089 Compare May 21, 2024 14:40
@aloneguid aloneguid added this to the 4.24.0 milestone May 22, 2024
aloneguid
aloneguid previously approved these changes May 22, 2024
Copy link
Owner

@aloneguid aloneguid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aloneguid aloneguid merged commit cd001fc into aloneguid:master May 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants