Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use poetry-dynamic-versioning #390

Merged
merged 1 commit into from
Dec 27, 2023
Merged

feat: Use poetry-dynamic-versioning #390

merged 1 commit into from
Dec 27, 2023

Conversation

hiohiohio
Copy link
Contributor

  • use poetry-dynamic-versioning to specify release version of the alpaca-py package by git tag of v0.0.0

AlexandrosKyriakakis
AlexandrosKyriakakis reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@AlexandrosKyriakakis AlexandrosKyriakakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we test that?

@hiohiohio
Copy link
Contributor Author

hiohiohio commented Dec 21, 2023 •
edited
Loading

did we test that?

Unfortunately, no. I have created this branch under my account. so cannot put a tag for dynamic versioning.
We can check behaviours after merging this PR. Failing dynamic-versioning should not be harmful or easy to revert.

@hiohiohio hiohiohio merged commit ba83efb into alpacahq:master Dec 27, 2023
5 checks passed
@hiohiohio hiohiohio deleted the use-poetry-dynamic-versioning branch December 27, 2023 03:52
@hiohiohio hiohiohio mentioned this pull request Dec 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandrosKyriakakis AlexandrosKyriakakis AlexandrosKyriakakis approved these changes

@sai-g sai-g Awaiting requested review from sai-g

@matebudai matebudai Awaiting requested review from matebudai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiohiohio @AlexandrosKyriakakis