Fix clang-format version in docs #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonEhrig
approved these changes
Sep 26, 2023
j-stephan
pushed a commit
to j-stephan/alpaka
that referenced
this pull request
Sep 27, 2023
bernhardmgruber
added a commit
that referenced
this pull request
Sep 27, 2023
SimeonEhrig
pushed a commit
that referenced
this pull request
Nov 15, 2023
* Switch to 1.0.0-rc1 * Silence more nvcc warnings * Add missing ALPAKA_UNREACHABLE * Silence more warnings Co-authored-by: Bernhard Manfred Gruber <[email protected]> * Disable activemask for SYCL Fixes: #2124 * refactor template order `allocMappedBufIfSupported` Move template `TPlatform` as the last template. There is no need to provide the platform template signature if we pass the platform as an instance. * Remove unused aliases * Only add clang warning flag when supported * Fix a warning with nvcc * Workaround gcc warning on uninitialized PlatformCpu * Fix warnings by clang * Suppress clang warnings in nvcc generated code * Pass alpaka_ENABLE_WERROR from environment to CMake * Disable GCC warning in nvcc generated code Fixes the following warning: ``` /builds/hzdr/crp/alpaka/test/unit/math/src/Defines.hpp:52:35: error: left operand of comma operator has no effect [-Werror=unused-value] 52 | for(size_t i = 0; i < argsItem.arity_nr; ++i) | ~~~~~~~~~^~~~~~~~~~ ``` * Workaround gcc warning on uninitialized PlatformUniformCudaHipRt * Fix OpenMP 5.1 atomics * Workaround clang not recognizing ternay expression * Implement atomicInc/atomicDec via omp critical Fixes: #2170 * Add clang-17 to CI Fixes: #2169 * Rename lambda captures to workaround warnings clang warns that the names of the captures shadow the outside variables. E.g.: QueueUniformCudaHipRt.hpp:215:57: error: declaration shadows a local variable [-Werror,-Wshadow-uncaptured-local] 215 | auto f = queue.m_callbackThread.submit([data = std::move(data)] { data->t(); }); | ^ * Exclude clang CUDA Debug builds from the CI They fail with: ptxas /tmp/randomStrategies-sm_61-768a17.s, line 14415; fatal : Parsing error near '.': syntax error ptxas fatal : Ptx assembly aborted due to errors clang++: error: ptxas command failed with exit code 255 (use -v to see invocation) * Add clang-17 to README.md CUDA/HIP/SYCL is marked as untested for now. * Fix clang-format version in docs (#2176) * Remove unnecessary -fintelfpga flag * Add changelog for alpaka v1.0.0 * Update author lists Co-authored-by: Bernhard Manfred Gruber <[email protected]> * Set release date in changelog --------- Co-authored-by: Jan Stephan <[email protected]> Co-authored-by: René Widera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation on the clang-format version we use is outdated in a few places. This PR fixes this.