Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trait IsKernelTriviallyCopyable #2302

Merged

Conversation

AuroraPerego
Copy link
Contributor

following the request in #2248, this adds the same trait introduced previously for kernel arguments also for the kernel itself, with the same approach used in #2198.

@AuroraPerego
Copy link
Contributor Author

I've no idea why the tests failed with rocm 5.7 and passed with 5.1 to 5.6 and 6.0 :(
The one that fails is mathTest, with Idx i: 634 computed : (0.890482,-7237.58) vs expected: (0.893934,-7237.59).

@psychocoderHPC psychocoderHPC added this to the 1.2.0 milestone Jul 3, 2024
@psychocoderHPC
Copy link
Member

I've no idea why the tests failed with rocm 5.7 and passed with 5.1 to 5.6 and 6.0 :( The one that fails is mathTest, with Idx i: 634 computed : (0.890482,-7237.58) vs expected: (0.893934,-7237.59).

looks like a small rounding issue, I would ignore it for now because it is hard to find. COuld be that we are to strict with the precision.

@psychocoderHPC psychocoderHPC merged commit 3468d2f into alpaka-group:develop Jul 5, 2024
22 checks passed
@AuroraPerego AuroraPerego deleted the triviallyCopiable branch August 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants